Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37582 )
Change subject: intel/fsp2_0: Make FSP_USE_REPO a SoC opt-in ......................................................................
Patch Set 12:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37582/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37582/5//COMMIT_MSG@10 PS5, Line 10: an list beeing
nit: a list being
Done
https://review.coreboot.org/c/coreboot/+/37582/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37582/6//COMMIT_MSG@7 PS6, Line 7: SOC
nit: I usually see SoC
Done
https://review.coreboot.org/c/coreboot/+/37582/6//COMMIT_MSG@7 PS6, Line 7: drivers/intel/fsp2_0: Make FSP_USE_REPO an SOC opt-in instead of list dependency
Can remove "instead of list dependency"
Done
https://review.coreboot.org/c/coreboot/+/37582/6//COMMIT_MSG@10 PS6, Line 10: ee
Only one `e`
Done
https://review.coreboot.org/c/coreboot/+/37582/6//COMMIT_MSG@11 PS6, Line 11: prune
typo: pr*o*ne
Done
https://review.coreboot.org/c/coreboot/+/37582/6//COMMIT_MSG@13 PS6, Line 13: is introducing
Use the same tense as the commit summary: introduces
Done
https://review.coreboot.org/c/coreboot/+/37582/6//COMMIT_MSG@14 PS6, Line 14: g
trailing `g`
Done
https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37582/6/src/soc/intel/cannonlake/Kc... PS6, Line 68: select HAVE_INTEL_FSP_REPO
Oh right, now I recall.
Done