build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44709 )
Change subject: soc/mediatek/mt8192: Add dramc 8 phase calibration ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/44709/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44709/1/src/soc/mediatek/mt8192/dra... PS1, Line 318: } else { else is not generally useful after a break or return
https://review.coreboot.org/c/coreboot/+/44709/1/src/soc/mediatek/mt8192/dra... PS1, Line 325: if (r_tmp > p_tmp) Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/44709/1/src/soc/mediatek/mt8192/dra... PS1, Line 327: else Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/44709/1/src/soc/mediatek/mt8192/dra... PS1, Line 330: if (err_code == 0) { Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/44709/1/src/soc/mediatek/mt8192/dra... PS1, Line 333: } else if (err_code < err_code_min) { Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/44709/1/src/soc/mediatek/mt8192/dra... PS1, Line 337: } else if (err_code >= err_code_min) { Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/44709/1/src/soc/mediatek/mt8192/dra... PS1, Line 339: if (loop_cnt > early_break_cnt) Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/44709/1/src/soc/mediatek/mt8192/dra... PS1, Line 346: } else { else is not generally useful after a break or return