[coreboot-gerrit] Change in coreboot[master]: vendorcode/siemens/hwilib: Fix current file string usage

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37077 )

Change subject: vendorcode/siemens/hwilib: Fix current file string usage
......................................................................

vendorcode/siemens/hwilib: Fix current file string usage

The CAR_GLOBAL accessors likely hid a bug where strncmp/cpy was passed
a pointer to a char array instead of the char array.

Change-Id: I68788e47ef27a959d6e048e9385afcfb663cdebc
Signed-off-by: Arthur Heymans 
---
M src/vendorcode/siemens/hwilib/hwilib.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/37077/1

diff --git a/src/vendorcode/siemens/hwilib/hwilib.c b/src/vendorcode/siemens/hwilib/hwilib.c
index 35fb4ce..a4b8e54 100644
--- a/src/vendorcode/siemens/hwilib/hwilib.c
+++ b/src/vendorcode/siemens/hwilib/hwilib.c
@@ -476,7 +476,7 @@
    	return CB_ERR_ARG;
    /* Check if this file is already open. If yes, just leave as there is
       nothing left to do here. */
-	if (!strncmp((char *)&current_hwi, hwi_filename, HWI_MAX_NAME_LEN)) {
+	if (!strncmp(current_hwi, hwi_filename, HWI_MAX_NAME_LEN)) {
    	printk(BIOS_SPEW, "HWILIB: File "%s" already open.\n",
    		hwi_filename);
    	return CB_SUCCESS;
@@ -543,7 +543,7 @@
    if (all_blocks[BLK_HIB] || all_blocks[BLK_SIB] || all_blocks[BLK_EIB] ||
        all_blocks[BLK_XIB]) {
    	/* Save currently opened hwi filename. */
-		strncpy((char *)&current_hwi, hwi_filename, HWI_MAX_NAME_LEN);
+		strncpy(current_hwi, hwi_filename, HWI_MAX_NAME_LEN);
    	return CB_SUCCESS;
    }
    else