[coreboot-gerrit] Change in ...coreboot[master]: ACPI: Correct asl_compiler_revision value

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31431 )

Change subject: ACPI: Correct asl_compiler_revision value
......................................................................

Patch Set 2:

(1 comment)

I like the idea overall.  I think we should get the version directly from the compiler, then encode it as BCD.

We can add the code to get the compiler version into genbuild_h:
  iasl -v | grep version | sed 's/.*version //'

This is a good first step to that though.
Thanks!

https://review.coreboot.org/#/c/31431/2/src/arch/x86/include/arch/acpi.h 
File src/arch/x86/include/arch/acpi.h:

https://review.coreboot.org/#/c/31431/2/src/arch/x86/include/arch/acpi.h@74 
PS2, Line 74: 20190108
maybe use BCD - 0x20190108 ?