EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48153 )
Change subject: soc/intel/alderlake: Align chipset.cb with pci_devs.h
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
@Subrata, can you give some comment for the EDS and the pci_devs.h are not identical?
/* PCH Devices */
#define PCH_DEV_SLOT_SIO0 0x10
#define PCH_DEVFN_THC0 _PCH_DEVFN(SIO0, 0)
#define PCH_DEVFN_THC1 _PCH_DEVFN(SIO0, 1)
#define PCH_DEVFN_CNVI_BT _PCH_DEVFN(SIO0, 2)
This is documentation issue, on ADL-P, we have THC0 as 0:0x10:0 where else on ADL-S its on 0:0x10:6 because I2C6 is on 0:0x10:0 there
So do we need to separate ADL-P and ADL-S in soc code? I think brya is use the ADL-P, will ADL-S be used for chrome or other coreboot project?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48153
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac33983dc12ed4e5b9257c50d82adc8e4e728ad6
Gerrit-Change-Number: 48153
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Tue, 01 Dec 2020 04:55:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment