[coreboot-gerrit] [M] Change in coreboot[main]: soc/intel/xeon_sp/skx: Configure IOAPICs

[Patrick Rudolph (Code Review)]

Attention is currently required from: Alicja Michalska, Christian Walter, Eric Lai, Felix Held, Johnny Lin, Jonathan Zhang, Shuo Liu, Tim Chu, [e-mail].

Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85170?usp=email )

Change subject: soc/intel/xeon_sp/skx: Configure IOAPICs
......................................................................

Patch Set 6:

(3 comments)

File src/soc/intel/xeon_sp/skx/ioapic.c:

https://review.coreboot.org/c/coreboot/+/85170/comment/b08fff2c_aacc10e8?usp... :
PS4, Line 47: 	}
> Is there special reason that in SKX, the linear GSI assignment is not usable? I guess is to match th […]

It cannot be assigned, can it?
But yes, it would match what is advertised using _PRT.

https://review.coreboot.org/c/coreboot/+/85170/comment/2ea1d136_55d823d7?usp... :
PS4, Line 49: i
> So, do we need to rebase this patch on https://review.coreboot. […]

Done

https://review.coreboot.org/c/coreboot/+/85170/comment/2944eca0_4083f359?usp... :
PS4, Line 61: 	.enable_resources = pci_dev_enable_resources,
> Are 0x2036/0x2026 PCI root port devices?

0x2036 and 0x2026 are the IOAPIC PCI IDs.