Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38221 )
Change subject: soc/amd/picasso: Drop forked copy of SMBus source ......................................................................
Patch Set 4:
I understand completely! I agree it's a real pain right now.
Marshall, if you do understand, why is there still a -2?
What's a pain (i.e. what I completely understand) is if someone wishes to build test changes in the picasso directory, they must checkout the entire work-in-progress stack up through the Mandolin mainboard.
That's not something you can expect of other developers. The mess one creates when submitting code to coreboot's master branch that is not hooked up for build testing, is their own burden.
Then once it's tested, that change needs to be brought over to a stack to be pushed. The reason for the -2 is that I don't want functioning picasso code ripped out, i.e. assuming one has the mainboard code commit.
Functioning? Can you please point me to the commit that makes use of this copy?
In my opinion, this patch should not preclude merging CB:38222. My recommended approach would be to submit that, abandon this one, then I or someone else can move the stoneyridge code to common.
Well, that implies that no API changes are done, otherwise this copy would break anyway. I haven't looked to far into Kyösti's queue, though.