Attention is currently required from: Raul Rangel, Martin L Roth, Jon Murphy, Martin Roth, Fred Reitberger, Tim Van Patten, Felix Held, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74093 )
Change subject: mb/google/myst: Add new mainboard
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/myst/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/74093/comment/648168f0_fc071c22
PS2, Line 2: SI_BIOS {
RECOVERY_MRC_CACHE should be 256K, same as the size of RW_MRC_CACHE […]
Fred, Why is the MRC region increasing? I would like to understand since the memory technology is the same in both Skyrim and Myst.
This has doubled between Guybrush and Skyrim. Now it has doubled again between Skyrim and Myst.
File src/mainboard/google/myst/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/74093/comment/98f5644d_a1ce8925
PS3, Line 36: }
RO should cover the lowest flash offsets. See the birman `chromeos_phoenix. […]
Given the lack of clarity on how things are looking for 32 MB SPI support, do you think we can address the comments for 16 MB layout and land that as a first pass.
Once the required support has landed, we can add the 32 MB layout.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7d731ce4d6cb6d4e9041f46eb5a799865bb0b9a
Gerrit-Change-Number: 74093
Gerrit-PatchSet: 6
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Tue, 04 Apr 2023 16:06:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment