Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36551 )
Change subject: soc/intel/tigerlake/include: Include headers from soc/intel/icelake
......................................................................
Patch Set 1:
(1 comment)
Please add headers in the same CL as where they are used. It's not possible to review them this way.
https://review.coreboot.org/c/coreboot/+/36551/1/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/ebda.h:
https://review.coreboot.org/c/coreboot/+/36551/1/src/soc/intel/tigerlake/inc...
PS1, Line 21: struct ebda_config {
: uint32_t signature; /* 0x00 - EBDA signature */
: uint32_t tolum_base; /* 0x04 - coreboot memory start */
: uint32_t reserved_mem_size; /* 0x08 - chipset reserved memory size */
: };
not needed anymore in master.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36551
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic957cb22d13415c46e5ef5eb681cbb5d511cb8b3
Gerrit-Change-Number: 36551
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Nov 2019 08:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment