Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56036 )
Change subject: mb/siemens/mc_ehl: Move SPD data to variant directory ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56036/comment/1a22c159_59252428 PS2, Line 7: # 0b000 Maybe just put the memory type here as a comment.
https://review.coreboot.org/c/coreboot/+/56036/comment/559f0783_ab46567f PS2, Line 8: LIB_SPD_DEPS := $(foreach f, $(SPD_SOURCES), \ : src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/spd/$(f).spd.hex) Do we really need this? There should be only one matching SPD file.