[coreboot-gerrit] Change in ...coreboot[master]: mb/google/poppy/variant/atlas: enable USB acpi

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30754 )

Change subject: mb/google/poppy/variant/atlas: enable USB acpi
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30754/1/src/mainboard/google/poppy/variants/... 
File src/mainboard/google/poppy/variants/atlas/devicetree.cb:

https://review.coreboot.org/#/c/30754/1/src/mainboard/google/poppy/variants/... 
PS1, Line 284: reset_gpio
> usb-acpi doesn't seem to have the concept of an enable_gpio. […]

Reset gpio is not used for asserting/de-asserting reset to a device using _ON/_OFF routines for USB. It is exposed to allow drivers to use it if required i.e. Bluetooth driver can use it to toggle reset if bluetooth gets into a bad state.

What is the use case for an enable gpio?