Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29986 )
Change subject: ACPI: Rename FADT model and set it to zero
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/29986/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29986/4//COMMIT_MSG@11
PS4, Line 11: compatibility with ACPI 1.0.
Please add a blank line below.
https://review.coreboot.org/#/c/29986/4//COMMIT_MSG@12
PS4, Line 12: So set this value to zero as we are using greater version than ACPI 1.0
Please add a dot/period at the end of the sentence.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29986
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I910ead4e5618c958a7989f4c309a3a4bb938e31a
Gerrit-Change-Number: 29986
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 Feb 2019 16:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment