Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34994 )
Change subject: arch/x86: Add postcar_frame_setup_top_of_dram_usage() API ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34994/2/src/arch/x86/postcar_loader... File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/34994/2/src/arch/x86/postcar_loader... PS2, Line 155: set_var_mtrr(mtrr, base, size, type); base is not checked if it's aligned to size.
https://review.coreboot.org/c/coreboot/+/34994/2/src/arch/x86/postcar_loader... PS2, Line 163: No need to enable intermediate caching in S3 That's not true for multiple reasons: - It depends on CONFIG_NO_STAGE_CACHE - even if the stage is cached it still needs to be copied where it will be executed.