Attention is currently required from: Simon Chou, TimLiu-SMCI, Paul Menzel, Christian Walter, Jian-Ming Wang, Arthur Heymans.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71959 )
Change subject: soc/intel/xeon_sp/Makefile.inc: Update makefile for spr
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/xeon_sp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/71959/comment/48ce4c93_18f0505b
PS2, Line 19: subdi
?
Done
File src/soc/intel/xeon_sp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/71959/comment/3ef94500_3c55bc30
PS4, Line 19: uncore_acpi
Why is this named differently than `nb_acpi. […]
Unified and renamed to uncore_acpi.c in CB:71959
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71959
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9429fe332bb5f01a41aa205c76ad9f0159f93eee
Gerrit-Change-Number: 71959
Gerrit-PatchSet: 7
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 02 Feb 2023 09:50:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment