Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44156 )
Change subject: mb/google/zork: Add kconfigs to check schematic version 3.6 ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44156/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44156/1//COMMIT_MSG@10 PS1, Line 10: VARIANT_MIN_BOARD_ID_V3_6_SCHEMATICS. It would be good to also mention that helper functions are added.
https://review.coreboot.org/c/coreboot/+/44156/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/44156/1/src/mainboard/google/zork/K... PS1, Line 195: non-CODEC_GPI pin for : HP_INT_ODL. nit: v3.6+ version of reference schematics.
https://review.coreboot.org/c/coreboot/+/44156/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/44156/1/src/mainboard/google/zork/v... PS1, Line 143: VARIANT_MIN_BOARD_ID_V3_6_SCHEMATICS CONFIG_VARIANT_MIN_BOARD_ID_V3_6_SCHEMATICS
https://review.coreboot.org/c/coreboot/+/44156/1/src/mainboard/google/zork/v... PS1, Line 150: * space before *
https://review.coreboot.org/c/coreboot/+/44156/1/src/mainboard/google/zork/v... PS1, Line 150: use spaces to align 'S' with 'p' on previous line.
https://review.coreboot.org/c/coreboot/+/44156/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/44156/1/src/mainboard/google/zork/v... PS1, Line 71: does NOT use v3.6 version of reference schematics uses CODEC_GPI pin for headphone jack interrupt.