Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44843 )
Change subject: cross-repo-cherrypick: Do not prepend "Original-" to "Cq-Depend:"
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44843/1/util/scripts/cross-repo-che...
File util/scripts/cross-repo-cherrypick:
https://review.coreboot.org/c/coreboot/+/44843/1/util/scripts/cross-repo-che...
PS1, Line 64: if (end==0) {
Thanks for taking this on! […]
I assumed that Cq-Depend will always be the first line in the last block. But you are right. If that assumption does not hold true, then the rest of the meta data will be in broken state.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44843
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0503234954f872ee56708e19e89cae9d9fa30df7
Gerrit-Change-Number: 44843
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 26 Aug 2020 22:01:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment