Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33104 )
Change subject: mb/apple/macbook21: Use common ACPI code
......................................................................
Patch Set 8:
Patch Set 8: Code-Review+1
Have you tried comparing the ACPI tables to see if there's any difference? Ideally, this refactoring would not change what the code does.
Well, if you just compare asl files, then of course there will be differences, as it's been rewritten with new syntax.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I790d1353adea432e9697c5edf0dbb7841d308728
Gerrit-Change-Number: 33104
Gerrit-PatchSet: 8
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Feb 2020 13:52:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment