Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38704 )
Change subject: soc/intel/tigerlake: Update PMC Register Base for JSP
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38704/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38704/1//COMMIT_MSG@9
PS1, Line 9: Update PCR_PSF3_TO_SHDW_PMC_REG_BASE_JSP to 0X0A00 for JSP
Can we please update the platform check also in espi,c?
else if (lpc_did_hi_byte == 0x38)
return PCH_JSP;
needs to be 4d
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38704
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6017a9703764b5454e7be479c1e08afe614908f1
Gerrit-Change-Number: 38704
Gerrit-PatchSet: 1
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 05 Feb 2020 18:22:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment