Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: soc/skl: Use devtree options to set primary GPU
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32044/1/src/soc/intel/skylake/romstage/romst...
File src/soc/intel/skylake/romstage/romstage_fsp20.c:
https://review.coreboot.org/#/c/32044/1/src/soc/intel/skylake/romstage/romst...
PS1, Line 282: PrimaryDisplay
I don't see any skylake/kabylake boards currently setting this in the device tree. And from the FSP UPD descriptions, it looks like the default value for this field is 3. So, if you plan to update the UPD, you will have to update all the boards which were defaulting to 3 to set this in their device tree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f9362676105e41c69139a094dbb9e8b865689f
Gerrit-Change-Number: 32044
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 27 Mar 2019 06:15:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment