Attention is currently required from: Nick Vaccaro, Zhuohao Lee, Alan Huang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58241 )
Change subject: mb/google/brya/variants/brask: Set PL and PsysPL ......................................................................
Patch Set 12:
(5 comments)
File src/mainboard/google/brya/variants/baseboard/brask/ramstage.c:
https://review.coreboot.org/c/coreboot/+/58241/comment/1f51d9fb_2ece8b0e PS12, Line 20: bool get_sku_index(const struct cpu_power_limits *limits, size_t num_entries, if you make this a static function then you don't need the prototype above.
https://review.coreboot.org/c/coreboot/+/58241/comment/6f954e8f_61861689 PS12, Line 121: nit: extra blank line
File src/mainboard/google/brya/variants/brask/ramstage.c:
PS12: Adding this file should be a separate change on top of the rest
https://review.coreboot.org/c/coreboot/+/58241/comment/62b930f6_0228b28a PS12, Line 21: * nit: space after `)`
https://review.coreboot.org/c/coreboot/+/58241/comment/6924eb62_8fcaeedb PS12, Line 41: barral `barrel`