30 May
2019
30 May
'19
9:11 a.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31517 )
Change subject: google/kukui: Enable display on internal panel ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/31517/11/src/mainboard/google/kukui/mainboar... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31517/11/src/mainboard/google/kukui/mainboar... PS11, Line 64: set_vbe_mode_info_valid this function needs KConfig to include MAINBOARD_DO_NATIVE_VGA_INIT or it will fail to compile.
please add that to Kconfig, or reorder this patch to be latter.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31517
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b3f04cc2d044789bab4c3f0f03b3a904714158f
Gerrit-Change-Number: 31517
Gerrit-PatchSet: 11
Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com
Gerrit-Reviewer: Chun-ta Lin itspeter@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com
Gerrit-CC: Daisuke Nojiri dnojiri@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: You-Cheng Syu youcheng@google.com
Gerrit-Comment-Date: Thu, 30 May 2019 07:11:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment