Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37289 )
Change subject: cpu/x86/smm: Add sinkhole mitigation to relocatable smmstub ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37289/1/src/cpu/x86/smm/smm_stub.S File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/37289/1/src/cpu/x86/smm/smm_stub.S@... PS1, Line 96: 1:
I'd just jump here from the later test in mitigate sinkhole. […]
oops, you're right, I missed that.
Doing a quick test with gnu as, it would still almost work out by accident though: the first two moves would be conflated into one (into edx, the upper 16 bit containing the opcode for the second move), so instead we'd get ?rash, with the first value being whatever happened to be in %al at the time.
Anybody trying to debug that would probably go crazy though.