HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31267 )
Change subject: mb/{asrock,intel,kontron}: Include missing <arch/io.h>
......................................................................
Patch Set 2:
(1 comment)
can you check if a timeless build produces the same binary with the
patch applied?
I'm not 100% sure if changing the order of the includes will change
things; since the code quality of x4x and sandybridge is rather
good, I don't really expect breakage from this though
sure, I will
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf2b41f471f531b2a9c3e620563e3c658dea4729
Gerrit-Change-Number: 31267
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Feb 2019 12:24:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment