Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47392 )
Change subject: WIP: soc/mediatek/mt8192: modify i2c and dma reset flow ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47392/3/src/soc/mediatek/common/i2c... File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/47392/3/src/soc/mediatek/common/i2c... PS3, Line 13: inline
Done
Not done.
https://review.coreboot.org/c/coreboot/+/47392/3/src/soc/mediatek/common/i2c... PS3, Line 15: struct
In order to maintain consistency with other references, const is not used in particular, and it may […]
Ack
https://review.coreboot.org/c/coreboot/+/47392/3/src/soc/mediatek/common/i2c... PS3, Line 16: struct
In order to maintain consistency with other references, const is not used in particular, and it may […]
Ack
https://review.coreboot.org/c/coreboot/+/47392/3/src/soc/mediatek/common/i2c... PS3, Line 17:
mtk_i2c_bus_init has used it.
What do you mean?
https://review.coreboot.org/c/coreboot/+/47392/3/src/soc/mediatek/common/i2c... PS3, Line 35: udelay(50);
That’s only required by the HW designers
Ack