Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun.
Hello Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Kapil Porwal, Nick Vaccaro, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86283?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: lib: Refactor ux_locales_get_text API ......................................................................
lib: Refactor ux_locales_get_text API
This patch refactors the `ux_locales_get_text` API to handle fallback text (English) internally, rather than relying on the caller. It introduces message IDs for lookups, enabling the API to locate both the UX locale name and fallback text based on the ID.
- ux_locales_get_text: Get UX locales message based on locales name. - ux_locales_get_text_by_id: Get UX locales message based on msg ID.
`ux_locales_get_text_by_id` retrieves fallback text message depending upon the message ID if UX locales not available. `ux_locales_get_text` API now takes an additional argument as `fallback_text` if provided, otherwise return `NULL`.
This centralizes fallback handling and simplifies adding future messages without per-SoC duplication.
BUG=b:339673254 TEST=Built and booted google/brox. Verified eSOL display.
Change-Id: I4952802396265b9ee8d164d6e43a7f2b3599d6c0 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/include/ux_locales.h M src/lib/ux_locales.c M src/soc/intel/alderlake/romstage/ux.c M src/soc/intel/meteorlake/romstage/fsp_params.c M tests/lib/ux_locales-test.c 5 files changed, 59 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/86283/3