Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47030 )
Change subject: sb/intel/lynxpoint/sata.c: Simplify RMW operations ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47030/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/c/coreboot/+/47030/2/src/southbridge/intel/lynxp... PS2, Line 16: static inline u32 sir_read(struct device *dev, int idx) : { : pci_write_config32(dev, SATA_SIRI, idx); : return pci_read_config32(dev, SATA_SIRD); : } : : static inline void sir_write(struct device *dev, int idx, u32 value) : { : pci_write_config32(dev, SATA_SIRI, idx); : pci_write_config32(dev, SATA_SIRD, value); : } : : static inline void sir_unset_and_set_mask(struct device *dev, int idx, u32 unset, u32 set)
These registers are platform-specific, but seem to match across most platforms. […]
The registers may be platform specific but the SIR mechanism and these helpers are not. thus, it should go to common code later