Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33775 )
Change subject: soc/intel/apollolake/romstage: Increase size of postcar stack
......................................................................
Patch Set 1: Code-Review-1
-1 because ppl tend to merge to early.
Comments of previous commit still apply. Please change all Intel platforms at once that use 1 KiB of stack as they are likely affected as well.
I'm fine with either values, but maybe it's time to use a common define instead of using a different value on each platform. In the end the postcar stage is the very same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba1fb5bfad6946f316feac2d8c998a782142a56a
Gerrit-Change-Number: 33775
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 25 Jun 2019 06:18:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment