22 Aug
2019
22 Aug
'19
2:15 a.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34948 )
Change subject: superio: nuvoton: add a driver for nct668xd ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34948/2/src/superio/nuvoton/nct668x... File src/superio/nuvoton/nct668xd/superio.c:
https://review.coreboot.org/c/coreboot/+/34948/2/src/superio/nuvoton/nct668x... PS2, Line 46: pnp_enable_resources
this conflicts with the second warning from the datasheet you mentioned in a comment in the header f […]
DEVICE_NOOP might be what you're looking for here
--
To view, visit https://review.coreboot.org/c/coreboot/+/34948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78eca4ba2948c36a386306887f62773580f6e444
Gerrit-Change-Number: 34948
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 22 Aug 2019 00:15:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment