Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42765 )
Change subject: soc/amd/common: Don't init SMIs or SCIs in psp_verstage
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42765/7/src/soc/amd/common/block/gp...
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42765/7/src/soc/amd/common/block/gp...
PS7, Line 221:
With the refactor we can just return here:
if (!can_set_smi_flags)
break;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40eb464cde6b233607de1e177702c643ea2b4bb2
Gerrit-Change-Number: 42765
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jul 2020 19:52:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment