Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt Papageorge, Felix Held. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55237 )
Change subject: soc/amd/common/fsp/pci: Add size field to PCIe interrupt routing HOB ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55237/comment/a021d6a5_9fd176a4 PS3, Line 18: Change
Add a Cq-depend: chrome-internal:3889619
I did not realize it was working now. Last time when making GOP changes I could not get Cq-depend in CB to work with FSP. Good to know.
File src/soc/amd/common/block/include/amdblocks/amd_pci_util.h:
https://review.coreboot.org/c/coreboot/+/55237/comment/f278efc6_3651e649 PS3, Line 55: struct pci_routing_info_hob { : uint32_t num_of_entries; : struct pci_routing_info routing_table[]; : } __packed; :
Can you move this struct into pci_routing_info.c. It's an implementation detail of FSP.
Done
File src/soc/amd/common/fsp/pci/pci_routing_info.c:
https://review.coreboot.org/c/coreboot/+/55237/comment/4920e5c8_9fc8e7bc PS3, Line 33: d
u?
This is not really needed. Was there mostly to aid in debug of the issue.