Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, SH Kim.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80324?usp=email )
Change subject: mb/google/brya/var/xol: Update devicetree
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/xol/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80324/comment/7ddbf646_4a424aaf :
PS1, Line 94: # Enable HDMI in PortB, HDMI/DP in Port1, Port2
: #register "ddi_ports_config" = "{
: # [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
: # //[DDI_PORT_1] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
: # //[DDI_PORT_3] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
: #}"
can we drop this ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80324?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I411932eb4872d77993394a290e8afdd1a0038faf
Gerrit-Change-Number: 80324
Gerrit-PatchSet: 1
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 02 Feb 2024 04:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment