Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45378 )
Change subject: nb/intel/ironlake: Drop casts from DEFAULT_{MCHBAR,DMIBAR} ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45378/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45378/1//COMMIT_MSG@10 PS1, Line 10:
Why is the distinction between ACPI and not ACPI not needed anymore?
The distinction is because ACPI doesn't understand C-style casts. However, these MMIO base addresses are used as pointers in C, so there was a cast for convenience.
I dropped the casts from the non-ACPI definitions for DEFAULT_MCHBAR and DEFAULT_DMIBAR. The end result is that both definitions are the same, so I collapsed them. The other casts that are dropped are the two uintptr_t casts in early_init.c (I think I ate a word, it should say `some other casts`). On Sandy Bridge, there were many more cases where casts could be dropped.
I'll try to add that `other` word to the commit message (or even reword it and mention early_init.c). However, I don't think it's useful to explain why the distinction is no longer necessary. I may add a sentence explaining why I want to remove the definition with casts (it's basically to not require any extra headers in memmap.h, added in a follow-up). And the reason I'm doing this is to uniformize old platforms.