Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33636 )
Change subject: drivers/intel/fsp: use ALIGN_UP instead of ALIGN for better readability ......................................................................
drivers/intel/fsp: use ALIGN_UP instead of ALIGN for better readability
Change-Id: I41fd50dc1e30332261f80e99419dad2635b5a54a Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/33636 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/drivers/intel/fsp1_0/fsp_util.c M src/drivers/intel/fsp1_1/raminit.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, approved
diff --git a/src/drivers/intel/fsp1_0/fsp_util.c b/src/drivers/intel/fsp1_0/fsp_util.c index 4e50abae..d787c7b 100644 --- a/src/drivers/intel/fsp1_0/fsp_util.c +++ b/src/drivers/intel/fsp1_0/fsp_util.c @@ -275,7 +275,7 @@ printk(BIOS_DEBUG, "Memory Configure Data Hob at %p (size = 0x%x).\n", (void *)mrc_hob_data, mrc_hob_size);
- output_len = ALIGN(mrc_hob_size, 16); + output_len = ALIGN_UP(mrc_hob_size, 16);
/* Save the MRC S3/fast boot/ADR restore data to cbmem */ mrc_data = cbmem_add (CBMEM_ID_MRCDATA, diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c index eff011a..a631fca 100644 --- a/src/drivers/intel/fsp1_1/raminit.c +++ b/src/drivers/intel/fsp1_1/raminit.c @@ -297,7 +297,7 @@ else if (!vboot_recovery_mode_enabled()) { /* Do not save MRC data in recovery path */ params->data_to_save = GET_GUID_HOB_DATA(mrc_hob); - params->data_to_save_size = ALIGN( + params->data_to_save_size = ALIGN_UP( ((u32)GET_HOB_LENGTH(mrc_hob)), 16); } }