[coreboot-gerrit] [S] Change in coreboot[main]: soc/amd/non_car/memlayout_x86.ld: Top align the code

[Martin L Roth (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81433?usp=email )

Change subject: soc/amd/non_car/memlayout_x86.ld: Top align the code
......................................................................

Patch Set 1:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81433/comment/b68b1867_6b20bb45 :
PS1, Line 26: bootlbock
bootblock

File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld:

https://review.coreboot.org/c/coreboot/+/81433/comment/43d5629c_eaf522c5 :
PS1, Line 128: 64K
I thought the whole point of this was that we didn't know the length, and it could be up to 128K with the next patch. I'm probably overlooking something, but this confuses me.

https://review.coreboot.org/c/coreboot/+/81433/comment/1f5ad78e_3171c778 :
PS1, Line 132: /* Trigger an error if I have an unusable start address */
We got rid of the assert, so remove this comment?

https://review.coreboot.org/c/coreboot/+/81433/comment/8dc49b85_588203ae :
PS1, Line 135: . = ALIGN(4096);
do we want a `. += 1` before the align? if we're already aligned, wouldn't this sequence lower the address by an additional 4K?