Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47434 )
Change subject: mb/google/volteer/variant/lindar: Add PMC.MUX.CONx device configuration for lindar
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47434/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/lindar/gpio.c:
https://review.coreboot.org/c/coreboot/+/47434/4/src/mainboard/google/voltee...
PS4, Line 19: /* A19 : DDSP_HPD1 ==> NOT USED */
: PAD_NC(GPP_A19, NONE),
: /* A20 : DDSP_HPD2 ==> NOT USED */
: PAD_NC(GPP_A20, NONE),
You can remove this and use the baseboard gpio.c setting instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5ee78b7ece8421144086af9b95f5f0d849be56c
Gerrit-Change-Number: 47434
Gerrit-PatchSet: 4
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Allen Cheng
allen.cheng@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting
lauren.ting@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 17 Nov 2020 06:55:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment