Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )
Change subject: AGESA: Fix discovery of IO APICs number
......................................................................
Patch Set 5: Code-Review-2
(1 comment)
Not urgent for POSTCAR_STAGE=y fix, postponed.
https://review.coreboot.org/c/coreboot/+/34589/5/src/drivers/amd/agesa/state...
File src/drivers/amd/agesa/state_machine.c:
https://review.coreboot.org/c/coreboot/+/34589/5/src/drivers/amd/agesa/state...
PS5, Line 305: amd_create_struct(&aip, AMD_INIT_EARLY, NULL, 0);
We don't link AMD_INIT_EARLY to ramstage at all in vendorcode.
vendorcode/amd/agesa/common/agesa-entry-cfg.h
It is there in the PI blob though, but we will not open up the can of worms of having multiple callsites with AMD_CREATE_STRUCT and same *params.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34589
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3ddfe606720143659e57fbbca7f7a3e655a7664
Gerrit-Change-Number: 34589
Gerrit-PatchSet: 5
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Sat, 23 Nov 2019 17:30:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment