EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59861 )
Change subject: mb/google/brya/var/felwinter: Correct garage wake event ......................................................................
mb/google/brya/var/felwinter: Correct garage wake event
Eject event is high. Set wake event to active high.
BUG=b:208937710 TEST=only release switch can wake system.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I568e9175c7a66599f7a525c32e4def7a79b55a0a --- M src/mainboard/google/brya/variants/felwinter/gpio.c M src/mainboard/google/brya/variants/felwinter/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/59861/1
diff --git a/src/mainboard/google/brya/variants/felwinter/gpio.c b/src/mainboard/google/brya/variants/felwinter/gpio.c index 4c07994..3f09d5b 100644 --- a/src/mainboard/google/brya/variants/felwinter/gpio.c +++ b/src/mainboard/google/brya/variants/felwinter/gpio.c @@ -10,7 +10,7 @@ /* A7 : SRCCLK_OE7# ==> PEN_DET_ODL */ PAD_CFG_GPI_GPIO_DRIVER(GPP_A7, NONE, DEEP), /* A8 : SRCCLKREQ7# ==> PEN_DET_ODL */ - PAD_CFG_GPI_SCI_LOW(GPP_A8, NONE, DEEP, EDGE_SINGLE), + PAD_CFG_GPI_SCI_HIGH(GPP_A8, NONE, DEEP, EDGE_SINGLE), /* B3 : PROC_GP2 ==> NC */ PAD_NC(GPP_B3, NONE), /* B5 : ISH_I2C0_SDA ==> NC */ diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb index 2cd5ad4..dafdbfc 100644 --- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb +++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb @@ -264,7 +264,7 @@ register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A7)" register "key.wake_gpe" = "GPE0_DW0_08" register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" - register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" + register "key.wakeup_event_action" = "EV_ACT_ASSERTED" register "key.dev_name" = ""EJCT"" register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_input_type" = "EV_SW"