Attention is currently required from: Hung-Te Lin, Paul Menzel, Xuxin Xiong, Yang Wu, Yidi Lin, Yu-Ping Wu.
Wentao Qin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82089?usp=email )
Change subject: mb/google/corsola/var/wugtrio: Add initialize of USB port 0
......................................................................
Patch Set 10:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82089/comment/aa643bdf_6f3b697e :
PS9, Line 7: Add initialization of
Initialize
Done
https://review.coreboot.org/c/coreboot/+/82089/comment/568b32a3_fc698161 :
PS9, Line 7: wugtrio
var/wugtrio
Done
https://review.coreboot.org/c/coreboot/+/82089/comment/7ad592ea_ea72ea92 :
PS9, Line 7: port0
I’d spell it with a space: port 0 […]
Done
https://review.coreboot.org/c/coreboot/+/82089/comment/06a5f6e7_06410340 :
PS9, Line 11:
Please describe the implementation. […]
Done
File src/soc/mediatek/mt8186/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/82089/comment/ed17c696_4a6ed858 :
PS9, Line 80: SSUSB_IPPC_BASE = IO_PHYS + 0x01283E00,
: SSUSB_IPPC_BASE_P0 = IO_PHYS + 0x01203E00,
Sort by addresses.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I725b80593f5fc498a204bf47f943c36ccbd78134
Gerrit-Change-Number: 82089
Gerrit-PatchSet: 10
Gerrit-Owner: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mingjin Ge
mingjin.ge@mediatek.corp-partner.google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 11:56:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment