Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
Patch Set 3:
(2 comments)
be aware that CBFS patch has been changed (and you just reverted it) - please rebase again with latest version before uploading new one.
https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 5: panel-AUO_B101UAN08_3 sort alphabetically (i.e., move AUO before BOE)
https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c:
https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 25: .name = "1200x1920@60Hz", do not declare name here.