Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: [WIP] soc/intel/apollolake: Drop select SMP
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43818/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43818/1//COMMIT_MSG@7
PS1, Line 7: [WIP] soc/intel/apollolake: Drop select SMP
intel/apollolake_rvp and intel/minnow3 do not specify the MAX_CPUS value.
Which seems wrong, unless there is single-core SKU on those.
Anyways with smp=N there is a real error with <smp/atomic.h> and <arch/smp/atomic.h> that this build showcases.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43818
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb4c7551031f4e32e01198261ee9ae9b95f18142
Gerrit-Change-Number: 43818
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 15:08:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment