[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8183: improve the DRAMC runtime config flow

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38490 )

Change subject: soc/mediatek/mt8183: improve the DRAMC runtime config flow
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/38490/1/src/soc/mediatek/mt8183/dra... 
File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:

https://review.coreboot.org/c/coreboot/+/38490/1/src/soc/mediatek/mt8183/dra... 
PS1, Line 326: 		(0x7 << 22) | (0x3 << 14) | (0x1 << 19) | (0x1 << 21));
> what's the align result? […]

I think it means this:

clrbits32(&ch[chn].ao.stbcal, (0x7 << 22) | (0x3 << 14) | (0x1 << 19) | (0x1 << 21));

It fits in 96 characters.

https://review.coreboot.org/c/coreboot/+/38490/1/src/soc/mediatek/mt8183/dra... 
PS1, Line 428: size_t
> it should u8, update it later

Done