[coreboot-gerrit] Change in coreboot[master]: arch/x86/car.ld: Use REGION macro

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36696 )

Change subject: arch/x86/car.ld: Use REGION macro
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36696/1/src/arch/x86/car.ld 
File src/arch/x86/car.ld:

https://review.coreboot.org/c/coreboot/+/36696/1/src/arch/x86/car.ld@38 
PS1, Line 38:  .,
> Should we add a new variant to memlayout. […]

I think for consistency with the pre-defined region macros (VBOOT2_WORK(), etc.) it would be better to use REGION() as is here.

https://review.coreboot.org/c/coreboot/+/36696/1/src/arch/x86/car.ld@109 
PS1, Line 109: 3
> rename

BTW you can just use '_' as a throwaway variable (that's what the memlayout macros do). There's no need to give them all different names.