[coreboot-gerrit] [S] Change in coreboot[main]: cpu/x86: Select proper SMM save Kconfig option

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jeff Daly, Jérémy Compostella, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Sean Rhodes, Subrata Banik, Tarun, Vanessa Eusebio, Werner Zeh.

Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83065?usp=email )

Change subject: cpu/x86: Select proper SMM save Kconfig option
......................................................................

Patch Set 4:

(3 comments)

Patchset:

PS4: 
Where is this usually documented?

It seems selecting from the sockets is unnecessary, as we want the disjunction
of what the selected CPUs select?

File src/cpu/intel/model_106cx/Kconfig:

https://review.coreboot.org/c/coreboot/+/83065/comment/20fca732_2ee1e960?usp... :
PS4, Line 16: 	select X86_EM64T101_SAVE_STATE
Is this right? legacy + 101? feels like one could fall into the gap...

File src/cpu/intel/model_f2x/Kconfig:

https://review.coreboot.org/c/coreboot/+/83065/comment/e2fa653a_e9e68155?usp... :
PS4, Line 10: 	select X86_EM64T101_SAVE_STATE
According to Wikipedia, 64-bit support started with Prescott (f3x):
https://en.wikipedia.org/wiki/List_of_Intel_Pentium_4_processors#Prescott_(9...

I guess it doesn't matter if they share the socket...

Again I'm surprised to see em64t10*1*