Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40929 )
Change subject: cpu: Add a helper function cpu_get_lapic_addr
......................................................................
Patch Set 6: Code-Review+2
Patch Set 5:
Patch Set 4: Code-Review+2
no one really moves apic addresses around. This should just work,and I'd argue we could just make this an inline.
Are you saying just get rid of LOCAL_APIC_ADDR altogether from coreboot?
No. I was just noting we probably could get away with just putting the decision in the header. It's not a big deal, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40929
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d9c50ee46804164712aaa22be1b434f800871ec
Gerrit-Change-Number: 40929
Gerrit-PatchSet: 6
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 May 2020 13:42:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment