Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35484 )
Change subject: util/supermicro: Add and use new tool smcbiosinfo ......................................................................
Patch Set 16:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35484/13/util/smc/smcbiosinfo/smcbi... File util/smc/smcbiosinfo/smcbiosinfo.c:
https://review.coreboot.org/c/coreboot/+/35484/13/util/smc/smcbiosinfo/smcbi... PS13, Line 113: ret = strtol(s, NULL, 0);
No check if it could be parsed? […]
Done
https://review.coreboot.org/c/coreboot/+/35484/15/util/supermicro/Makefile.i... File util/supermicro/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35484/15/util/supermicro/Makefile.i... PS15, Line 4: SMCBIOSINFOTOOL:= $(obj)/smcbiosinfo
We also have an $(objutil) but, meh, I don't know when to use it...
Done
https://review.coreboot.org/c/coreboot/+/35484/15/util/supermicro/Makefile.i... PS15, Line 6: util/supermicro/smcbiosinfo
This could be $(dir), IIRC.
Done
https://review.coreboot.org/c/coreboot/+/35484/15/util/supermicro/Makefile.i... PS15, Line 7: MAKE
s/MAKE /HOSTCC/ ?
Done