Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42521 )
Change subject: mb/pcengines/apu2: Switch to proper GPIO API ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42521/13/src/mainboard/pcengines/ap... File src/mainboard/pcengines/apu2/gpio_ftns.c:
https://review.coreboot.org/c/coreboot/+/42521/13/src/mainboard/pcengines/ap... PS13, Line 14: GPIO_49
did you verify that this is the correct gpio number? haven't looked in the datasheet, but from the d […]
This SoC carried two enumerations for GPIOs in the docs, making it confusing indeed.
52740 Rev 3.06 - March 18, 2016
Table 303: Function name for GPIOx[1FC:100:step4] Register Reset Function GPIOx100 0000_0000h GPIO49_AGPIO64 GPIOx104 0014_0000h GPIO50_AGPIO65
Same bit, read8 GPIOx102 bit 0 vs read32 GPIOx100 bit 16.