[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Configure GPIO pad for non-inversion

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................

mb/google/hatch: Configure GPIO pad for non-inversion

This implementation configures GPIO (GPP_A21, GPP_C21, GPP_D16)
pad in non-inversion mode i.e Rx PAD state is not inverted as
it is sent from GPIO to IOAPIC.

BUG=b:123315212
TEST=Tested for below:
     -> Verify touchpad is working fine.
     -> TPM init is successful and boot with fixed boot media.

Change-Id: I6034fd07ccc96a19218d57ef8bb9049c4b963ea5
Signed-off-by: Aamir Bohra 
Reviewed-on: https://review.coreboot.org/c/31328
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Paul Menzel 
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
1 file changed, 24 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index f8d5d7d..badd978 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -27,8 +27,12 @@
    PAD_CFG_GPO(GPP_A18, 1, DEEP),
    /* WWAN_RADIO_DISABLE_1V8_ODL */
    PAD_CFG_GPO(GPP_A19, 1, DEEP),
-	/* TRACKPAD_INT_ODL */
-	PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, INVERT),
+	/*
+	 * TRACKPAD_INT_ODL
+	 * TODO Configure it back to invert mode, when
+	 * ITSS IPCx configuration is fixed in FSP.
+	 */
+	PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, NONE),
    /* SRCCLKREQ1 */
    PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1),
    /* PCIE_14_WLAN_CLKREQ_ODL */
@@ -67,8 +71,12 @@
    PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1),
    /* PCH_WP_OD */
    PAD_CFG_GPI(GPP_C20, NONE, DEEP),
-	/* H1_PCH_INT_ODL */
-	PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, INVERT),
+	/*
+	 * H1_PCH_INT_ODL
+	 * TODO Configure it back to invert mode, when
+	 * ITSS IPCx configuration is fixed in FSP.
+	 */
+	PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, NONE),
    /* EC_IN_RW_OD */
    PAD_CFG_GPI(GPP_C22, NONE, DEEP),
    /* WLAN_PE_RST# */
@@ -83,8 +91,12 @@
    PAD_NC(GPP_D8, NONE),
    /* TOUCHSCREEN_RST_L */
    PAD_CFG_GPO(GPP_D15, 0, DEEP),
-	/* TOUCHSCREEN_INT_L */
-	PAD_CFG_GPI_APIC(GPP_D16, NONE, DEEP, LEVEL, INVERT),
+	/*
+	 * TOUCHSCREEN_INT_L
+	 * TODO Configure it back to invert mode, when
+	 * ITSS IPCx configuration is fixed in FSP.
+	 */
+	PAD_CFG_GPI_APIC(GPP_D16, NONE, DEEP, LEVEL, NONE),
    /* SATAGP1 */
    PAD_CFG_NF(GPP_E1, NONE, DEEP, NF2),
    /* M2_SSD_PE_WAKE_ODL */
@@ -181,8 +193,12 @@
    PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1),
    /* H1_SLAVE_SPI_MOSI_R */
    PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1),
-	/* H1_PCH_INT_ODL */
-	PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, INVERT),
+	/*
+	 * H1_PCH_INT_ODL
+	 * TODO Configure it back to invert mode, when
+	 * ITSS IPCx configuration is fixed in FSP.
+	 */
+	PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, NONE),
    /* WLAN_PE_RST# */
    PAD_CFG_GPO(GPP_C23, 1, DEEP),
 };