Attention is currently required from: Furquan Shaikh, Rizwan Qureshi.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54734 )
Change subject: src/intel/microcode: Add support for extended signature table
......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS8:
Seems like this change caused regressions: https://ticket.coreboot. […]
Pending my approval on ticket.coreboot.org, does CB:56153 fix the issue?
File src/cpu/intel/microcode/microcode.c:
https://review.coreboot.org/c/coreboot/+/54734/comment/ebf02b0b_27d64916
PS8, Line 139: size_t ext_tbl_len = ucode->total_size - size;
ssize_t could be useful here to avoid overflows. […]
CB:56153 is my suggestion
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1466caf4a4ba1f9a0214bdde19cce57dd65dacbd
Gerrit-Change-Number: 54734
Gerrit-PatchSet: 8
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 19:52:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment