Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38577 )
Change subject: nb/intel/sandybridge: improve indexed register helper macros
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38577/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38577/1//COMMIT_MSG@7
PS1, Line 7: improve
Since the factor it gets multiplied by is a power of two and the bits where it gets shifted to are z […]
The bits aren't necessarily zero, hence the plus sign.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b0d5172394ff65edfe57bdad474631938e58872
Gerrit-Change-Number: 38577
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 26 Jan 2020 23:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment