Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43766 )
Change subject: security/vboot/Makefile.inc: Update regions-for-file function ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43766/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43766/3//COMMIT_MSG@7 PS3, Line 7: /Makefile.inc
you don't need to mention the filename, directory is good enough
Having filename, indicates wherein the change is added. In this case, I'm ok for this.
https://review.coreboot.org/c/coreboot/+/43766/3/src/security/vboot/Makefile... File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43766/3/src/security/vboot/Makefile... PS3, Line 176: $(if $(filter \ : $(if $(filter y,$(CONFIG_VBOOT_STARTS_IN_ROMSTAGE)), \ : %/romstage,) \ : mts \ : %/verstage \ : locales \ : locale_%.bin \ : font.bin \ : vbgfx.bin \ : rmu.bin \ : cmos_layout.bin \ : cmos.default \ : $(call strip_quotes,$(CONFIG_RO_REGION_ONLY)) \ : ,$(1)),COREBOOT,\ : $(if $(filter \ : $(call strip_quotes,$(CONFIG_RWA_REGION_ONLY)) \ : ,$(1)), FW_MAIN_A, \ : $(if $(filter \ : $(call strip_quotes,$(CONFIG_RWB_REGION_ONLY)) \ : ,$(1)), FW_MAIN_B, \ : $(if $(filter \ : $(call strip_quotes,$(CONFIG_RW_REGION_ONLY)) \ : ,$(1)), $(RW_PARTITIONS), $(VBOOT_PARTITIONS) ) \ : ))))))
I think this can be shifted left one tab, the `$(if $(filter ` should line up with `$(regions-for-f […]
Ack